Re: new module 'unused-parameter'

[Simon Josefsson]

Simon Josefsson <address@hidden> writes:

> Bruno Haible <address@hidden> writes:
>
>> Hi Jim,
>>
>> Eric wrote:
>>> Also, se-context.in.h and se-selinux.in.h would benefit from an 
>>> unused-parameter module.
>>
>> Here's a proposed patch to make the generated selinux/selinux.h and
>> selinux/context.h files independent of the stuff defined in config.h.
>
> I suspect this patch is the reason for a recent build failure on MinGW,
> see bottom of:
>
> http://autobuild.josefsson.org/gnulib/log-200912271011859192000.txt
>
> Any ideas?

The reason was that selinux/selinux.h was built before
unused-parameters.h, so the unused-parameters.h file that was inserted
into selinux/selinux.h was empty.  I pushed the trivial dependency
addition below.

/Simon

>From fd3a867e03f91196aa121ff196e1bff2340edab4 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Tue, 29 Dec 2009 08:02:30 +0100
Subject: [PATCH] modules/selinux-h: Depend on $(UNUSED_PARAMETER_H).

---
 ChangeLog         |    5 +++++
 modules/selinux-h |    4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index a5c7e46..60a9b56 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-12-29  Simon Josefsson  <address@hidden>
+
+       * modules/selinux-h (selinux/selinux.h, selinux/context.h): Depend
+       on $(UNUSED_PARAMETER_H) to avoid build failure.
+
 2009-12-28  Jim Meyering  <address@hidden>
 
        update-copyright: you may specify a max. line length other than 72
diff --git a/modules/selinux-h b/modules/selinux-h
index a715a2c..12dd20d 100644
--- a/modules/selinux-h
+++ b/modules/selinux-h
@@ -21,7 +21,7 @@ Makefile.am:
 lib_SOURCES += se-context.in.h se-selinux.in.h
 
 BUILT_SOURCES += selinux/selinux.h
-selinux/selinux.h: se-selinux.in.h
+selinux/selinux.h: se-selinux.in.h $(UNUSED_PARAMETER_H)
        $(AM_V_at)$(MKDIR_P) selinux
        $(AM_V_GEN)rm -f address@hidden $@ && \
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */' && \
@@ -36,7 +36,7 @@ selinux/selinux.h: se-selinux.in.h
 MOSTLYCLEANFILES += selinux/selinux.h selinux/selinux.h-t
 
 BUILT_SOURCES += $(SELINUX_CONTEXT_H)
-selinux/context.h: se-context.in.h
+selinux/context.h: se-context.in.h $(UNUSED_PARAMETER_H)
        $(AM_V_at)$(MKDIR_P) selinux
        $(AM_V_GEN)rm -f address@hidden $@ && \
        { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */' && \
-- 
1.6.5.7