bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix build failure with getline.c


From: Eric Blake
Subject: Re: [PATCH] fix build failure with getline.c
Date: Fri, 01 Jan 2010 06:37:01 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Robert Millan on 1/1/2010 5:56 AM:
> When importing getline.c into GNU GRUB, it failed to build due to undefined
> ssize_t.  Here's a fix (I believe including <sys/types.h> is portable enough,
> please let me know if I'm wrong).

Hmm.  The prototype for getline lives in <stdio.h>, so the real bug is
that our replacement <stdio.h> is not guaranteeing that ssize_t is
defined.  Which platform was this failure on?  Perhaps it resulted from
Bruno's attempts to reduce namespace pollution on glibc machines, coupled
with an older glibc that didn't yet expose everything required by POSIX 2008?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAks9+n0ACgkQ84KuGfSFAYDANgCguyQDALhDLxJnaf7CO5OqSmk4
UE4AoKNn1G6AIDUYgiaMVu00g6tLa0dd
=Pn9x
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]