bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug 552320] Handling AT_FDCWD as EBADF in glibc's utimens() causes


From: Jim Meyering
Subject: Re: [Bug 552320] Handling AT_FDCWD as EBADF in glibc's utimens() causes tar failures
Date: Wed, 06 Jan 2010 07:47:42 +0100

Eric Blake wrote:
...
> s/futimes/futimens/ (ChangeLog and commit message)

Thanks!

>> +++ b/lib/utimens.c
>> @@ -264,19 +264,20 @@ fdutimens (char const *file, int fd, struct timespec 
>> const timespec[2])
>>          }
>>  # endif /* HAVE_UTIMENSAT */
>>  # if HAVE_FUTIMENS
>> -      {
>> -        result = futimens (fd, ts);
>> +      if (0 <= fd)
>> +    {
>
> Why the TAB?  We just got rid of those in gnulib.

My emacs code had not been informed about gnulib's change,
so I actually inserted them as I wrote that patch.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]