[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: failing SIGNATURE_CHECK's due to undefined types
From: |
Ralf Wildenhues |
Subject: |
Re: failing SIGNATURE_CHECK's due to undefined types |
Date: |
Wed, 6 Jan 2010 22:46:14 +0100 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
Hi Eric,
* Eric Blake wrote on Wed, Jan 06, 2010 at 10:15:43PM CET:
> Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes:
>
> > > Do we need to be using AC_USE_SYSTEM_EXTENSIONS for pread?
> >
> > I don't think AC_USE_SYSTEM_EXTENSIONS defines _XOPEN_SOURCE. I'm not
> > sure it should though, it also disables some APIs on some systems.
>
> On Linux, AC_USE_SYSTEM_EXTENSIONS defines _GNU_SOURCE, which in turn turns
> on
> anything inside _XOPEN_SOURCE but without crippling items that would be
> excluded by strict adherence to _XOPEN_SOURCE. So, if I'm not mistaken, this
> patch should fix things (although it will be a few more hours before I have
> access to a Linux box to verify).
Yep, it does.
> > The following two failures remain:
> >
> > $ gnulib-tool --with-tests --test dirent
> > [...]
> > ../../gltests/test-dirent.c:26: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
> > ‘__attribute__’ before ‘i’
>
> And this patch should fix that.
Yep. Thanks!