Re: Incorrect use of USE_XATTR in coreutils-8.4

[Pádraig Brady]

On 22/01/10 17:09, Jim Meyering wrote:
> Eric Blake wrote:
> > According to Jim Meyering on 1/22/2010 6:17 AM:
> > > However, it'd sure be nice to use something more generic than
> > > lib/config.h.  IMHO, autoconf should make configure AC_SUBST its
> > > currently-internal-only CONFIG_HEADERS variable.  While we wait,
> > > I suppose we can kludge it by extracting the first file name
> > > from the use of AC_CONFIG_HEADER(S)? in configure.ac.
> >
> > And what's wrong with AH_HEADER?  It should be possible to do something
> > like (untested):
> >
> > AC_CONFIG_COMMANDS_PRE([m4_ifdef([AH_HEADER],
> >   [AC_SUBST([CONFIG_HEADER], m4_defn([AH_HEADER]))])])
>
> I didn't know we could do that ;-)
> And it's even documented.
> Thanks!
>
> Then, to enable maint.mk to rely on a definition of $(CONFIG_HEADER)
> we could add something like the above to modules/maintainer-makefile:
>
>      configure.ac:
>      AC_CONFIG_COMMANDS_PRE([m4_ifdef([AH_HEADER],
>        [AC_SUBST([CONFIG_HEADER], m4_defn([AH_HEADER]))])])

The attached gnulib patch (summarized below) seems to work.

cheers,
Pádraig.

--- a/modules/maintainer-makefile
+++ b/modules/maintainer-makefile

+configure.ac:
+AC_CONFIG_COMMANDS_PRE([m4_ifdef([AH_HEADER],
+  [AC_SUBST([CONFIG_INCLUDE], m4_defn([AH_HEADER]))])])
+

--- a/top/maint.mk
+++ b/top/maint.mk

+# #if HAVE_... will evaluate to false for any non numeric string.
+# That would be flagged by using -Wundef, however gnulib currently
+# tests many undefined macros, and so we can't enable that option.
+# So at least preclude common boolean strings as macro values.
+sc_Wundef_boolean:
+       @grep -Ei '^#define.*(yes|no|true|false)$$' '$(CONFIG_INCLUDE)' && \
+         { echo 'Use 0 or 1 for macro values' 1>&2; exit 1; } || :
+

config-bool-macro.diff
Description: Text Data