[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)
From: |
Eric Blake |
Subject: |
Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined) |
Date: |
Mon, 25 Jan 2010 13:11:12 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
According to Grégoire Sutre on 1/25/2010 2:53 AM:
> Hi,
>
> This message concerns both gnulib and grub. As discussed on irc and on
> the list [1], ENABLE_NLS is not used correctly, which leads to a build
> failure when gettext is not detected (or with configure option
> --disable-nls).
>
> ENABLE_NLS is defined in AM_GNU_GETTEXT and the documentation of this
> macro [2] does not require ENABLE_NLS to be defined when gettext is not
> available. However, uses of ENABLE_NLS assume it to be defined, which
> is not correct.
I see no reason to make this change. The C preprocessor guarantees that
#if ENABLE_NLS is treated identically to #if 0 if ENABLE_NLS is undefined.
There are many more instances of this paradigm in gnulib; changing just
ENABLE_NLS is inappropriate. Use of -Wundef with gnulib is unsupported.
--
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
signature.asc
Description: OpenPGP digital signature