[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ‘pty’ module fails on FreeBSD 7.2
From: |
Eric Blake |
Subject: |
Re: ‘pty’ module fails on FreeBSD 7.2 |
Date: |
Wed, 17 Mar 2010 09:45:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3 |
On 03/17/2010 08:24 AM, Ludovic Courtès wrote:
>> Yes, you have to unset the cache variable before the second test,
>> ac_cv_have_decl_forkpty.
>
> Then I think this patch should fix it:
>
> 2010-03-17 Ludovic Courtès <address@hidden> (tiny change)
>
> * m4/pty.m4: Unset $ac_cv_have_decl_forkpty before the second
> `AC_CHECK_DECL' invocation.
Except that you no longer benefit from caching on platforms that really
do lack forkpty; if the cache contains ac_cv_have_decl_forkpty=no, then
you are forcing the user to waste time repeating the check to reset it
back to no.
A better fix would be to test for the existence of both headers
(<util.h> and <libutil.h>), then write a single AC_CHECK_DECL with a
prefix of:
#if HAVE_UTIL_H
# include <util.h>
#endif
#if HAVE_LIBUTIL_H
# include <libutil.h>
#endif
I'll try and write a patch along these lines shortly...
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- ‘pty’ module fails on FreeBSD 7.2, Ludovic Courtès, 2010/03/16
- Re: ‘pty’ module fails on FreeBSD 7.2, Ralf Wildenhues, 2010/03/16
- Re: ‘pty’ module fails on FreeBSD 7.2, Ludovic Courtès, 2010/03/17
- Re: ‘pty’ module fails on FreeBSD 7.2,
Eric Blake <=
- [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Simon Josefsson, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/19
- [PATCH 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/19
- [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18