Re: [PATCH] gethostname: fix build on mingw

[Eric Blake]

On 03/19/2010 05:35 PM, Matthias Bolte wrote:
>> I believe this will solve the issue, but would appreciate some testing
>> by Matthias.  I also think that this is the same issue as:
>> http://lists.gnu.org/archive/html/bug-gnulib/2010-01/msg00183.html
>>
> 
> I tested this patch and can confirm that this patch fixes the
> gethostname compile issue on MinGW. Thanks.

I think the patch works for including <sys/socket.h> first, but what
happens if you include <unistd.h> or <winsock2.h> first?  I think
there's still some circularities that need to be resolved.  That is,
gnulib's unistd.h needs to be smarter about ensuring that winsock2.h is
completely included prior to getting to its own replacements.  I'm
working on a respin along these lines...

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature