bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv4] gethostname: fix build on mingw


From: Bruno Haible
Subject: Re: [PATCHv4] gethostname: fix build on mingw
Date: Mon, 22 Mar 2010 20:47:55 +0100
User-agent: KMail/1.9.9

Eric Blake wrote:
> +/* Get all possible declarations of gethostname().  */
> +#if @UNISTD_H_HAVE_WINSOCK2_H@ && !defined _GL_INCLUDING_WINSOCK2_H
> +# define _GL_INCLUDING_WINSOCK2_H
> +# include <winsock2.h>
> +# undef _GL_INCLUDING_WINSOCK2_H
> +#endif
> 

Would it be possible to conditionalize this with
  #if @GNULIB_GETHOSTNAME@
like it was before? In a package that has nothing to do with
sockets and nothing to do with gethostname(), I wouldn't want to
see all <winsock2.h> definitions in virtually all compilation units.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]