bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] glob: synchronize from glibc


From: Bert Wesarg
Subject: Re: [PATCH 1/3] glob: synchronize from glibc
Date: Tue, 23 Mar 2010 08:34:58 +0100

On Tue, Mar 23, 2010 at 00:34, Eric Blake <address@hidden> wrote:
> diff --git a/ChangeLog b/ChangeLog
> index 5153846..b2e66e4 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,11 @@
> +2010-03-22  Eric Blake  <address@hidden>
> +
> +       glob: synchronize from glibc
> +       * lib/glob.c (glob): Lose register modifier.  Drop redundant
> +       code.
> +       (globfree): Drop useless if-before-free.
> +       (collated_compare): Add const-safety.
> +
>  2010-02-17  Eric Blake  <address@hidden>
>
>        manywarnings: add more warnings
> diff --git a/lib/glob.c b/lib/glob.c
> index 03b55df..deceeb7 100644
> --- a/lib/glob.c
> +++ b/lib/glob.c
> @@ -256,10 +256,10 @@ int
>  GLOB_ATTRIBUTE
>  #endif
>  glob (pattern, flags, errfunc, pglob)
> -     const char * restrict pattern;
> +     const char *pattern;

Thats 'restrict' not 'register'.

>      int flags;
>      int (*errfunc) (const char *, int);
> -     glob_t * restrict pglob;
> +     glob_t *pglob;

Ditto.

>  {
>   const char *filename;
>   const char *dirname;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]