[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: sc_Wundef_boolean
From: |
Simon Josefsson |
Subject: |
Re: sc_Wundef_boolean |
Date: |
Wed, 24 Mar 2010 13:05:34 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
Pádraig Brady <address@hidden> writes:
> On 24/03/10 08:56, Simon Josefsson wrote:
>> This syntax-check warning appears to fail:
>>
>> address@hidden:~/src/libidn master$ make sc_Wundef_boolean
>> Wundef_boolean
>> grep: : No such file or directory
>> address@hidden:~/src/libidn master$
>>
>> Any reason we can't use the normal VC_LIST_EXCEPT instead? It will
>> check more files than just config.h. Alternatively, use VC_LIST_EXCEPT
>> as a fall back if CONFIG_INCLUDE is not available, which happens when
>> autoreconf/configure haven't been run yet.
>
> I'd rather restrict it to the config header as
> the matching expression is quite general.
>
> The attached patch just skips the check if the
> config header is not present.
That approach works for me, please push.
Thanks,
/Simon