bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] build: sync primary and tests-related gnulib module lists


From: Jim Meyering
Subject: [PATCH] build: sync primary and tests-related gnulib module lists
Date: Wed, 24 Mar 2010 19:36:32 +0100

This patch is for information/discussion only.
With today's wctob build failure problem and with two or three
similar incidents recently, I wanted a way to automatically
derive the list of modules used in gnulib-tests, but not in lib/.
Here it is (see the "comm" use below).  What to do with that list
is another matter.

In the case of wctob, it was clearly needed in lib/,
since dfa.c uses the function.

I don't want to add all of the modules listed here
and have begun to prune the list, but there are more to go.
For example, we'll keep c-ctype, because grep will soon use it.
Similarly, I wouldn't be surprised to see uses of inttostr or quote.
However, most of the rest are truly unnecessary.

>From 966429dfc2b6d8e2fa1ecdc7d31ff89cd7849c0e Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Wed, 24 Mar 2010 19:28:36 +0100
Subject: [PATCH] build: sync primary and tests-related gnulib module lists

* bootstrap.conf (gnulib_modules): Synchronize the primary list
of modules with the list used by tests, so that we don't have
a repeat of the wctob-vs-Solaris 8 build failure.
I've omitted argmatch, since it would evoke a new warning,
pathmax because we shouldn't be using it and hash-pjw since
its absence obviously will not cause trouble.
I used this command to obtain the list of modules:
comm -13 <(grep 'begin gnulib module' lib/gnulib.mk|sort) \
    <(grep 'begin gnulib module' gnulib-tests/gnulib.mk \
      |grep -ve '-tests$'|sort)\
  | sed 's/.* //' | grep -Ev '^(argmatch|dummy|pathmax|hash-pjw)$'
---
 bootstrap.conf |   20 ++++++++++++++++----
 1 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index df7b95f..9db6a8d 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -23,10 +23,13 @@ announce-gen
 atexit
 binary-io
 btowc
+c-ctype
 closeout
+c-strcase
 dirent
 dirname
 do-release-commit-and-tag
+dup2
 error
 exclude
 fcntl-h
@@ -34,18 +37,21 @@ fnmatch
 getopt-gnu
 getpagesize
 gettext
-git-version-gen
 gitlog-to-changelog
-gnu-web-doc-update
+git-version-gen
 gnupload
+gnu-web-doc-update
 hard-locale
 ignore-value
 intprops
+inttostr
 isdir
-lseek
 locale
-malloc
+lseek
+lstat
 maintainer-makefile
+malloc
+malloca
 manywarnings
 mbrlen
 mbrtowc
@@ -54,9 +60,13 @@ mempcpy
 obstack
 open
 progname
+putenv
+quote
 quotearg
 realloc
 regex
+same-inode
+setenv
 ssize_t
 stddef
 stdlib
@@ -67,9 +77,11 @@ strtol
 strtoul
 strtoull
 strtoumax
+symlink
 sys_stat
 unistd
 unlocked-io
+unsetenv
 update-copyright
 useless-if-before-free
 wchar
--
1.7.0.3.435.g097f4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]