Re: new syntax-check rule for @acronym?

[Simon Josefsson]

Eric Blake <address@hidden> writes:

> On 03/24/2010 01:46 AM, Simon Josefsson wrote:
>>>     syntax-check test for this seems useful, to foster harmonization across
>>>     GNU packages.  How about the patch below?
>>>
>>> I have no objection, certainly.
>> 
>> I pushed the patch below.
>>  
>> +# Don't use Texinfo @acronym{} as it is not a good idea.
>> +sc_texinfo_acronym:
>> +    @grep -nE '@acronym{'                                           \
>> +        $$($(VC_LIST_EXCEPT) | grep -E '\.texi$$') &&               \
>> +      { echo '$(ME): found use of Texinfo @acronym{}' 1>&2;         \
>> +        exit 1; } || :
>
> This hangs for non-GNU projects, like libvirt, that have no .texi
> documentation.

Solved like this, thanks.

/Simon

>From decf3017fc407865acdaa20ee4795b50a010239a Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Fri, 26 Mar 2010 09:14:34 +0100
Subject: [PATCH] top/maint.mk (sc_texinfo_acronym): Don't infloop if there is 
no *.texi files.

Reported by Eric Blake <address@hidden>.
---
 ChangeLog    |    5 +++++
 top/maint.mk |    9 ++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5b11d62..d833549 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-03-26  Simon Josefsson  <address@hidden>
+
+       * top/maint.mk (sc_texinfo_acronym): Don't infloop if there is
+       no *.texi files.  Reported by Eric Blake <address@hidden>.
+
 2010-03-25  Eric Blake  <address@hidden>
 
        maint: use pragma consistently across replacement headers
diff --git a/top/maint.mk b/top/maint.mk
index 09da20a..6127c57 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -563,10 +563,13 @@ sc_GFDL_version:
 
 # Don't use Texinfo @acronym{} as it is not a good idea.
 sc_texinfo_acronym:
-       @grep -nE '@acronym{'                                           \
-           $$($(VC_LIST_EXCEPT) | grep -E '\.texi$$') &&               \
+       @if $(VC_LIST_EXCEPT) | grep -lE '\.texi$$' >/dev/null; then    \
+               grep -nE '@acronym{'                                    \
+                       $$($(VC_LIST_EXCEPT) | grep -E '\.texi$$') &&   \
          { echo '$(ME): found use of Texinfo @acronym{}' 1>&2;         \
-           exit 1; } || :
+           exit 1; } || :;                                             \
+       else :;                                                         \
+       fi
 
 cvs_keywords = \
   Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State
-- 
1.7.0.3