bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sun C++ bug with stdbool


From: Eric Blake
Subject: Re: Sun C++ bug with stdbool
Date: Fri, 16 Apr 2010 17:18:50 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4

On 04/16/2010 05:07 PM, Paul Eggert wrote:
> Eric Blake <address@hidden> writes:
> 
>> The problem we're up against is a broken C++ compiler.
> 
> Thanks, I understand now.
> 
>> what preprocessor flags to we examine in order to skip that
>> particular portion of test-stdbool.c only for CC?  Or do we go full-bore
>> and use #if 0, skipping test f everywhere?
> 
> How about guarding it with "#if defined __GNUC__ || !defined __cplusplus"?
> 
> Come to think of it, shouldn't the other instances "#if 0" in that file
> be "#ifdef __GNUC__"?  For example, I don't see why the last "#if 0" is
> needed, as it guards code that is already guarded by "#if defined
> __xlc__ || defined __GNUC__".

Yeah, it sounds like a good idea to tighten some of those tests, as an
overall audit of the file.  I'm out of time today, but will look at it
again on Monday if no one else beats me.  Meanwhile, I took Paolo's
advice and committed the stop-gap patch that just extends the #if 0
region, so bison should be able to use today's gnulib to compile under CC.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]