Re: git-version-gen not EBCDIC compatible

[Eric Blake]

[redirecting to bug-gnulib, as owner of the file in question]

On 04/26/2010 07:16 AM, Steve Goetze wrote:
> The following line in m4-1.4.14/build-aux/git-version-gen causes a build
> failure on z/OS (EBCDIC codeset):
> 
> # Omit the trailing newline, so that m4_esyscmd can use the result directly.
> echo "$v" | tr -d '\012'
> 
> Octal 12 does not represent new line in EBCDIC.

Thanks for the report.  I'll push this patch shortly for
git-version-gen, but there are other culprits (MODULES.html.sh,
gnupload, m4/get{delim,line}.m4, m4/javacomp.m4, posix-modules) that are
still ascii-specific.

diff --git i/ChangeLog w/ChangeLog
index 786f89e..6076afd 100644
--- i/ChangeLog
+++ w/ChangeLog
@@ -1,3 +1,10 @@
+2010-04-26  Eric Blake  <address@hidden>
+
+       git-version-gen: allow use on EBCDIC hosts.
+       * build-aux/git-version-gen (dirty): Use literal rather than tying
+       ourselves to ascii.
+       Reported by Steve Goetze.
+
 2010-04-23  Eric Blake  <address@hidden>

        open_memstream: new module
diff --git i/build-aux/git-version-gen w/build-aux/git-version-gen
index e754c77..be85b6d 100755
--- i/build-aux/git-version-gen
+++ w/build-aux/git-version-gen
@@ -1,6 +1,6 @@
 #!/bin/sh
 # Print a version string.
-scriptversion=2010-02-24.17; # UTC
+scriptversion=2010-04-26.15; # UTC

 # Copyright (C) 2007-2010 Free Software Foundation, Inc.
 #
@@ -140,7 +140,8 @@ case "$dirty" in
 esac

 # Omit the trailing newline, so that m4_esyscmd can use the result
directly.
-echo "$v" | tr -d '\012'
+echo "$v" | tr -d '
+'

 # Local variables:
 # eval: (add-hook 'write-file-hooks 'time-stamp)


-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature