Re: ‘libunistring’ module errors

[Bruno Haible]

Hi Ludo,

> With the current ‘libunistring’ Gnulib module, I’m observing [0] this
> [0] http://hydra.nixos.org/build/429165/

Huh? Under that URL, I don't see a 'configure' failure, but rather an error

  
/nix/store/w10yf4is48ff61ysfr7l0pi1whgqyr1w-libunistring-0.9.3/include/unistr.h:197:7:
 error: "CONFIG_UNICODE_SAFETY" is not defined

that is due to the simultaneous use of -Wundef and -Werror, which is not
supported by gnulib nor libunistring.

> during the ‘configure’ run:
> 
> --8<---------------cut here---------------start------------->8---
> ./configure: line 20186: test: -lt: unary operator expected
> ./configure: line 20187: test: -eq: unary operator expected
> ./configure: line 20223: test: -lt: unary operator expected
> ./configure: line 20224: test: -eq: unary operator expected
> 
> [...]
> 
> --8<---------------cut here---------------end--------------->8---
> 
> stemming from these lines:
> 
> --8<---------------cut here---------------start------------->8---
>             test $LIBUNISTRING_VERSION_MAJOR -lt 0 \
>             || { test $LIBUNISTRING_VERSION_MAJOR -eq 0 \
>                  && { test $LIBUNISTRING_VERSION_MINOR -lt 9 \
>                       || { test $LIBUNISTRING_VERSION_MINOR -eq 9 \
>                            && test $LIBUNISTRING_VERSION_SUBMINOR -lt 2
>                          }
>                     }
>                }
> --8<---------------cut here---------------end--------------->8---

These error messages would indicate that LIBUNISTRING_VERSION_MAJOR and
LIBUNISTRING_VERSION_MINOR are either unset or empty. Can you verify
that the 'configure' file contains the statements to set these variables
before they are used? An AC_REQUIRE should ensure this ordering, but
who knows what went wrong.

> Before, ‘configure’ reported this:
> 
> --8<---------------cut here---------------start------------->8---
> checking for libunistring... yes
> checking how to link with libunistring... -lunistring
> checking for libunistring version... 0.9.3
> --8<---------------cut here---------------end--------------->8---
> 
> So, two problems here:
> 
>   1. The tests above are underquoted, they should read:
> 
>        test "$LIBUNISTRING_VERSION_MAJOR" -lt 0 \
>           ...

No, they are correctly quoted. $LIBUNISTRING_VERSION_MAJOR is supposed
to be a non-empty sequence of digits. The purpose of not writing
  "$LIBUNISTRING_VERSION_MAJOR"
is to get you to report this problem.

>   2. The version-extraction sed scripts appear to be broken:
> 
> --8<---------------cut here---------------start------------->8---
> $ 
> gl_libunistring_sed_extract_subminor='/^[0-9][0-9]*[.][0-9][0-9]*[.][0-9]/{s/^[0-9]*[.][0-9]*[.]\([0-9]*\).*/\1/p;q;}
> > i\
> > 0
> > q
> > '
> 
> $ echo 0.9.3 | sed -n -e "$gl_libunistring_sed_extract_major"
> 
> $ sed --version
> GNU sed version 4.1.5

Unfortunately I cannot reproduce this:

gl_libunistring_sed_extract_major='/^[0-9]/{s/^\([0-9]*\).*/\1/p;q;}
i\
0
q
'
gl_libunistring_sed_extract_minor='/^[0-9][0-9]*[.][0-9]/{s/^[0-9]*[.]\([0-9]*\).*/\1/p;q;}
i\
0
q
'
gl_libunistring_sed_extract_subminor='/^[0-9][0-9]*[.][0-9][0-9]*[.][0-9]/{s/^[0-9]*[.][0-9]*[.]\([0-9]*\).*/\1/p;q;}
i\
0
q
'
echo 0.9.3 | sed -n -e "$gl_libunistring_sed_extract_major"
echo 0.9.3 | sed -n -e "$gl_libunistring_sed_extract_minor"
echo 0.9.3 | sed -n -e "$gl_libunistring_sed_extract_subminor"
sed --version

produces:

0
9
3
GNU sed Version 4.1.5
Copyright (C) 2003 Free Software Foundation, Inc.
(Der folgende Text ist eine nicht überprüfte Übersetzung, die zur
 Information dient;  in rechtlichen Fragen ist immer das englische
 Original ausschlaggebend)

Dieses Program ist freie Software; In den Quelldateien können Sie die
Bedingungen für die Weitergabe nachlesen.
Es gibt KEINE GARANTIE; nicht einmal die implizite Garantie der
MARKTFÄHIGKEIT oder der ERFÜLLUNG EINES BESTIMMTEN ZWECKES.

Can you provide a "How to reproduce"? Possibly by uploading or sending me
privately the tarball that you are using (the real tarball being used,
after the repackaging done by Nix or Hydra)?

Bruno