btw, gl_SNPRINTF_RETVAL_C99 was expanded before it was required...

[Jim Meyering]

When running the new test,

     ./gnulib-tool --create-testdir --with-tests --test inttostr

I saw lots of warnings like this go by:

    configure.ac:170: warning: AC_REQUIRE: `gl_SNPRINTF_RETVAL_C99' was 
expanded before it was required
    glm4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from...
    glm4/snprintf-posix.m4:7: gl_FUNC_SNPRINTF_POSIX is expanded from...
    configure.ac:29: gl_INIT is expanded from...
    configure.ac:170: the top level
    executing autoconf
    configure.ac:170: warning: AC_REQUIRE: `gl_SNPRINTF_RETVAL_C99' was 
expanded before it was required
    glm4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from...
    glm4/snprintf-posix.m4:7: gl_FUNC_SNPRINTF_POSIX is expanded from...

but the test did pass, so I nearly forgot about them.
It's a classic, and the fix is trivial.
Bruno, ok to push?

>From 7449b1d57b95574aee5831b35a22c3ec7e4d92a5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 10 Jun 2010 15:21:09 +0200
Subject: [PATCH] printf.m4: avoid autoconf's "Expanded Before Required" warning

* m4/printf.m4 (gl_SNPRINTF_RETVAL_C99): Define using AC_DEFUN_ONCE,
rather than AC_DEFUN, to avoid the classic "Expanded Before Required"
autoconf warning.
---
 ChangeLog    |    5 +++++
 m4/printf.m4 |    4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8cfeff5..187ee7c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2010-06-10  Jim Meyering  <address@hidden>

+       printf.m4: avoid autoconf's "Expanded Before Required" warning
+       * m4/printf.m4 (gl_SNPRINTF_RETVAL_C99): Define using AC_DEFUN_ONCE,
+       rather than AC_DEFUN, to avoid the classic "Expanded Before Required"
+       autoconf warning.
+
        inttostr: add a new function, inttostr, and tests
        The namesake function was not available.  The existence of the
        template file, inttostr.c makes its addition nontrivial.
diff --git a/m4/printf.m4 b/m4/printf.m4
index ebca536..b31efe3 100644
--- a/m4/printf.m4
+++ b/m4/printf.m4
@@ -1,4 +1,4 @@
-# printf.m4 serial 33
+# printf.m4 serial 34
 dnl Copyright (C) 2003, 2007-2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -1101,7 +1101,7 @@ dnl     }
 dnl     ---------------------------------------------------------------------
 dnl Result is gl_cv_func_snprintf_retval_c99.

-AC_DEFUN([gl_SNPRINTF_RETVAL_C99],
+AC_DEFUN_ONCE([gl_SNPRINTF_RETVAL_C99],
 [
   AC_REQUIRE([AC_PROG_CC])
   AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles
--
1.7.1.501.g23b46