[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] inttostr-tests: depend on snprintf, not snprintf-posix
From: |
Jim Meyering |
Subject: |
[PATCH] inttostr-tests: depend on snprintf, not snprintf-posix |
Date: |
Thu, 10 Jun 2010 18:55:16 +0200 |
I've just noticed that snprintf-posix includes this notice:
Comment:
This module should not be used as a dependency from a test module,
otherwise when this module occurs as a tests-related module, it will
have side effects on the compilation of the 'vasnprintf' module, if
that module occurs among the main modules in lib/.
Yet, the inttostr tests require the ability to use %jd and %ju formats,
so I've changed that module to depend on the snprintf module instead.
Without that, coreutils bootstrap would fail like this:
./bootstrap: m4/xsize.m4 overrides ._bootmp2/m4/xsize.m4
./bootstrap: aclocal --force -I m4 ...
missing file gnulib-tests/vasnprintf.c
configure.ac:45: error: expected source file, required through
AC_LIBSOURCES, not found
m4/gnulib-comp.m4:1729: gl_INIT is expanded from...
configure.ac:45: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: autom4te failed with exit status: 1
>From 8adc6bf3253f630d833f6a39d0d594f4e0daf4e9 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 10 Jun 2010 18:35:59 +0200
Subject: [PATCH] inttostr-tests: depend on snprintf, not snprintf-posix
* modules/inttostr-tests (Depends-on): Depend on snprintf, not
snprintf-posix, to avoid this aclocal failure:
missing file gnulib-tests/vasnprintf.c
configure.ac:45: error: expected source file, required through \
AC_LIBSOURCES, not found
---
ChangeLog | 7 +++++++
modules/inttostr-tests | 2 +-
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 187ee7c..debb6af 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2010-06-10 Jim Meyering <address@hidden>
+ inttostr-tests: depend on snprintf, not snprintf-posix
+ * modules/inttostr-tests (Depends-on): Depend on snprintf, not
+ snprintf-posix, to avoid this aclocal failure:
+ missing file gnulib-tests/vasnprintf.c
+ configure.ac:45: error: expected source file, required through \
+ AC_LIBSOURCES, not found
+
printf.m4: avoid autoconf's "Expanded Before Required" warning
* m4/printf.m4 (gl_SNPRINTF_RETVAL_C99): Define using AC_DEFUN_ONCE,
rather than AC_DEFUN, to avoid the classic "Expanded Before Required"
diff --git a/modules/inttostr-tests b/modules/inttostr-tests
index 69716d2..f935d90 100644
--- a/modules/inttostr-tests
+++ b/modules/inttostr-tests
@@ -4,7 +4,7 @@ tests/test-inttostr.c
Depends-on:
intprops
inttypes
-snprintf-posix
+snprintf
configure.ac:
--
1.7.1.501.g23b46
- [PATCH] inttostr-tests: depend on snprintf, not snprintf-posix,
Jim Meyering <=