[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Question about critical_factorization() in the Two-Way algorithm
|
From: |
Pádraig Brady |
|
Subject: |
Re: Question about critical_factorization() in the Two-Way algorithm |
|
Date: |
Wed, 23 Jun 2010 01:39:30 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 22/06/10 15:42, Eric Blake wrote:
> On 06/22/2010 08:41 AM, Eric Blake wrote:
>> On 06/22/2010 08:34 AM, Pádraig Brady wrote:
>>> Cool, that's what I expected from the names.
>>> So do we just need to move a docs around a little like:
>>>
>>
>> Yes, that looks like an appropriate patch. Please apply.
>
> I spoke too soon. We would also need to patch m4/memmem.m4 to actually
> perform the empty needle verification in the memmem-simple case.
I also noticed the empty needle verification didn't
check that the correct pointer was returned,
and only checked for !NULL. So I rolled that
fix into the attached reorg.
cheers,
Pádraig.
gnulib-memmem.diff
Description: Text Data