bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] lib-symbol-versions: fix m4 quoting


From: Eric Blake
Subject: [PATCH 2/2] lib-symbol-versions: fix m4 quoting
Date: Thu, 26 Aug 2010 17:11:31 -0600

* m4/ld-version-script.m4 (gl_LD_VERSION_SCRIPT): Use correct
format for AC_LINK_IFELSE.

Signed-off-by: Eric Blake <address@hidden>
---

Last one, at least according to an autoconf run on:

gnulib-tool --create-testdir --dir=t $(gnulib-tool --list)

as that was faster than waiting for --create-megatestdir to complete
(but, I'm still running the megatestdir, since it found the btowc
issue, and may find others).

Hmmm - this is the first time that AC_LANG_SOURCE was already there,
but it was underquoted (that is, it was expanded too early, so the
witness macro was lost by the time it was inside the AC_LINK_IFELSE).
I'm betting that autoconf 2.68 will flush out a lot of packages with
insufficient quoting ;)

 ChangeLog               |    4 ++++
 m4/ld-version-script.m4 |    4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d526df2..8f12bcc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2010-08-26  Eric Blake  <address@hidden>

+       lib-symbol-versions: fix m4 quoting
+       * m4/ld-version-script.m4 (gl_LD_VERSION_SCRIPT): Use correct
+       format for AC_LINK_IFELSE.
+
        glob: fix compile test
        * m4/glob.m4 (gl_GLOB): Use correct format for AC_COMPILE_IFELSE.

diff --git a/m4/ld-version-script.m4 b/m4/ld-version-script.m4
index 43c1ef1..8fd8c89 100644
--- a/m4/ld-version-script.m4
+++ b/m4/ld-version-script.m4
@@ -1,4 +1,4 @@
-# ld-version-script.m4 serial 1
+# ld-version-script.m4 serial 2
 dnl Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -34,7 +34,7 @@ VERS_2 {
         global: sym;
 } VERS_1;
 EOF
-    AC_LINK_IFELSE(AC_LANG_PROGRAM([], []),
+    AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])],
                    [have_ld_version_script=yes], [have_ld_version_script=no])
     rm -f conftest.map
     LDFLAGS="$save_LDFLAGS"
-- 
1.7.2.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]