bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: accept4: depend on socklen


From: Ralf Wildenhues
Subject: Re: accept4: depend on socklen
Date: Sat, 28 Aug 2010 11:23:06 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

Hi Bruno,

* Bruno Haible wrote on Sat, Aug 28, 2010 at 10:23:23AM CEST:
> > I needed this on some system but forgot which.
> 
> AFAICT, the systems which lack socklen_t are:
> HP-UX 10.20, IRIX 6.5, Interix 3.5, BeOS.
> 
> >     accept4: depend on socklen
> 
> This patch is incomplete, because according to POSIX, <sys/socket.h> ought
> to provide socklen_t, even if the user does not use any functions from this
> header file. Likewise for <netdb.h>.

Ah, ok.

> >  Depends-on:
> > -sys_socket
> >  accept
> >  fcntl-h
> >  binary-io
> >  extensions
> > +socklen
> > +sys_socket
> 
> sys_socket is at the beginning because it's the most important dependency
> for this module, namely the module which provides the header file. Keep
> most important things first, please.

Oops, my volatile memory somehow remembered patches that ordered
dependencies, but sure, makes sense like this.

> I'm applying this patch instead. Can you report success or failure when
> you had a chance to test it on one of the platforms listed above, please?

I ran the following on HP-UX 10.20:

for m in sys_socket netdb getaddrinfo getsockopt setsockopt socklen \
        "sys_socket netdb getaddrinfo getsockopt setsockopt socklen"
do
  ../gnulib/gnulib-tool --with-tests --test $m || break
done

I confirmed that the configure output contained text like:

| checking for socklen_t... no
| checking for socklen_t equivalent... int

As an aside, the for loop failed at some point because the *&$"# HP-UX
shell ran out of unused temporary file names in /tmp.  Autoconf has for
a while now some constructs that let old shells forget to clean up here
document temporary files after themselves.  I keep seeing that on a few
of the old unixes, but since the failure is rather spurious, I've never
made an effort to actually analyze and fix this.  Guess that's another
TODO item ...

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]