strsignal on NetBSD [was: m4-1.4.15 issues]

[Eric Blake]

[adding bug-gnulib, after sanitizing some details]

On 09/09/2010 02:36 PM, Nelson H. F. Beebe wrote:
> I got m4-1.4.15 to build on NetBSD 5.0.2 with this
> source code patch, and change in compiler options:
>
>   % diff -c tests/test-strsignal.c.~1~ tests/test-strsignal.c
> *** tests/test-strsignal.c.~1~  Mon Mar  8 14:47:55 2010
> --- tests/test-strsignal.c      Thu Sep  9 14:23:51 2010
> ***************
> *** 21,26 ****
> --- 21,28 ----
>
>    #include<string.h>
>
> + #include<unistd.h>
> +
>    #include "signature.h"
>    SIGNATURE_CHECK (strsignal, char *, (int));

That's a bug in NetBSD's headers (POSIX requires strsignal in 
<string.h>, not <unistd.h>), but one that we can easily work around, by 
making our replacement <string.h> pick up <unistd.h> for NetBSD.  Thanks 
for the report.

> Add -D_NETBSD_SOURCE to CFLAGS to expose the hidden prototype
> of strsignal:

Hmm - I don't see _NETBSD_SOURCE listed in m4/extensions.m4; maybe that 
means gl_USE_SYSTEM_EXTENSIONS needs to be aware of yet another spelling 
to get this automatically added to config.h?

> The test suite then reported:
>
> FAIL: test-nl_langinfo.sh

Bruno may have more ideas about how to tackle this failure.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org