Re: [libvirt] [PATCH] autogen: added glibtool and pkg-config checks

[Eric Blake]

[adding bug-gnulib]

On 09/15/2010 06:36 AM, Justin Clift wrote:
> OSX MacPorts has libtool named as glibtool, with libtoolize
> named as glibtoolize.  This patch adds support for this, and also
> adds a check for pkg-config, to warn when it is missing.

Hmm - would it be easier to make bootstrap.conf list pkg-config as a 
prerequisite, rather than having to hack up autogen.sh to do that?

Also, if I'm reading the code right, changing bootstrap.conf to list 
'libtoolize' instead of 'libtool' as the prerequisite will let you get 
by with overriding just $LIBTOOLIZE instead of both $LIBTOOL and 
$LIBTOOLIZE.

Additionally it may be sufficient to just teach upstream 
gnulib/build-aux/bootstrap to use 'find_tool LIBTOOLIZE libtoolize 
glibtoolize', at which point re-syncing to upstream bootstrap will 
automatically pick up on the right libtool for MacOS without you having 
to hack libvirt's autogen.sh in the first place :)

So, NACK to this version of the libvirt patch, and instead let me do 
some gnulib work...  Not to mention that Gary is working on some 
upstream patches to improve bootstrap modularity, and there is also a 
request to add 'bootstrap --skip-git' that I need to respond to...

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org