|
| From: | Eric Blake |
| Subject: | Re: A fix for pmccabe2html |
| Date: | Mon, 20 Sep 2010 08:49:37 -0600 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.3 |
On 09/19/2010 04:54 PM, Reuben Thomas wrote:
After investigation, I think I found the bug: cut_dir should not be
hardwired to "/../", but rather set to "${top_srcdir}/". Otherwise, it
does not work for a typical in-tree build: cut_dir is not found in the
path, index returns 0, and an arbitrary few characters are cut off the
front of each file's path. The fix is therefore to remove the
initialization of cut_dir from pmccabe2html (1 line) and add "-v
cut_dir=${top_srcdir}/" to the Makefile.am code.
Rather than describing the fix, could you post this as a patch? -- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |