|
| From: | Eric Blake |
| Subject: | Re: what does regex depend on sys_wait? |
| Date: | Tue, 28 Sep 2010 10:34:19 -0600 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4 |
On 09/28/2010 10:30 AM, Eric Blake wrote:
On 09/28/2010 10:28 AM, Paul Eggert wrote:How about this patch? (I hope it's noninvasive enough. :-)Nope, it breaks things on mingw, where we need the sys_wait replacement to define macros like WEXITSTATUS in the first place before they can be reused in the stdlib replacement. :(+++ b/modules/stdlib @@ -11,7 +11,6 @@ c++defs include_next stddef stdint -sys_wait unistd warn-on-use
However, in thinking about it a bit more, a compromise would be to also modify tests/test-stdlib.c to check for the presence of whether the gnulib sys_wait module is in use, and skip validation of the status-related macros if it is not. Then, stdlib can drop the sys_wait dependency, and if you care about the macros, it's not that much harder to additionally request the sys_wait module.
-- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |