Re: [libvirt] [PATCH] autogen: allow aclocal to receive arguments via an environment variable

[Eric Blake]

On 09/30/2010 03:04 PM, Jim Meyering wrote:
> Eric Blake wrote:
> > [moving to bug-gnulib]
> > On 09/19/2010 01:21 AM, Justin Clift wrote:
> ...
> > >    The next step is to get all required pieces from gnulib,
> > >    to run autoreconf, and to invoke ./configure:
> > >
> > > diff --git a/bootstrap b/bootstrap
> > > index 2422549..593e0b2 100755
> > > --- a/bootstrap
> > > +++ b/bootstrap
> > > @@ -775,7 +775,7 @@ grep -E '^[  ]*AC_CONFIG_HEADERS?\>' configure.ac>/dev/null 
> > > ||
> > >
> > >    for command in \
> > >      libtool \
> > > -  "${ACLOCAL-aclocal} --force -I m4" \
> > > +  "${ACLOCAL-aclocal} --force -I m4 ${ACLOCAL_FLAGS}" \
> >
> > At first glance, this actually looks reasonable to me.  Anyone else
> > have any comments or ideas for a better approach?
>
> Looks fine to me, but please drop the curly braces
> from the new variable reference.

Done, and pushed in Justin's name.  I added (tiny change) in the 
ChangeLog to reflect that Justin does not have FSF copyright assignment 
on file for gnulib (although technically, it appears that Red Hat has 
blanket assignment).

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org