bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] getdate: rename to get_date


From: Eric Blake
Subject: Re: [PATCH] getdate: rename to get_date
Date: Thu, 30 Sep 2010 15:46:41 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4

On 09/30/2010 03:35 PM, Bruno Haible wrote:
Eric Blake wrote:
I went with get_date, and not Bruno's parse-datetime.  Afterall,
parse-duration supplies the parse_duration function, and
get_date supplies the get_date function.

Well, my suggestion implied to rename the function as well, not
only the module :-)

At which point _all_ clients would instantly be exposed to the rename in C code, and we might as well drop even having the obsolete getdate wrapper module; whereas by keeping getdate.h and get_date(), clients only have to update their gnulib-tool list and maybe a one-liner include change in their texinfo documentation.

I guess it's up to Jim whether the more radical rename makes sense.


2010-09-30  Bruno Haible<address@hidden>

        More renaming from 'getdate' to 'get_date'.
        * doc/get_date.texi: Renamed from doc/getdate.texi.
        * modules/get_date (Files): Update.
        * MODULES.html.sh (Date and time<time.h>): Update.
        * DEPENDENCIES: Update.
        * gnulib-tool: Update comment.
        * m4/bison.m4 (gl_BISON): Likewise.
        * m4/get_date.m4 (gl_GET_DATE): Likewise.

Thanks for that additional cleanup.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]