Re: Fwd: sed porting trouble

[Jim Meyering]

Eric Blake wrote:
> On 10/05/2010 04:49 AM, Jim Meyering wrote:
>> Thus, technically we must now remember that for each new
>> @address@hidden .in.h file, we must also use @address@hidden
>>
>> That deserves a syntax-check rule in Makefile.
>
> Makes sense to me.
>
>> I've added this:
>> +sc_pragma_columns:
>> +    if test -d .git; then                                           \
>> +          git ls-files|grep '\.in\.h$$'                                     
>> \
>
> Hmm - in coreutils' case where gnulib is a submodule, 'git ls-files'
> doesn't recurse into the submodule, so you won't have any coverage of
> the *.in.h files when running 'make syntax-check' in coreutils.  And
> I'm not sure how often, if it is even possible, that 'make
> syntax-check' gets run directly on gnulib.  Does this rule need a bit
> of tweaking to ensure that it visits gnulib files even when they don't
> belong to the VCS of the project that included gnulib as a submodule?

This syntax check is for gnulib itself, i.e.,
to be run in a cloned gnulib source directory.
"make syntax-check".

It's not related to maint.mk's syntax-check rules.

As to when it's run, that's up to each developer.
It'd be good to put it on a hook or a
cron job somewhere, but that's for personal use.