|
| From: | Eric Blake |
| Subject: | Re: [PATCH] memmem, strstr, strcasestr: fix bug with long periodic needle |
| Date: | Thu, 07 Oct 2010 07:52:45 -0600 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4 |
On 10/05/2010 05:42 PM, Bruno Haible wrote:
Hi Eric,- #if CYGWIN_VERSION_DLL_MAJOR>= 1007 + #if CYGWIN_VERSION_DLL_MAJOR>= 1007&& CYGWIN_VERSION_DLL_MINOR> 7I think this conditional expression will evaluate to false for Cygwin 1.8.0, 1.9.5, and so on, which is not intended.
Indeed. And stdio_h.m4 already uses the correct idiom: #if CYGWIN_VERSION_DLL_COMBINED > CYGWIN_VERSION_DLL_MAKE_COMBINED (1007, 7)
There are 6 occurrences of this expression.
Now fixed. -- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |