Re: [libvirt] [PATCH] Conditionally include termios.h

[Eric Blake]

[adding bug-gnulib]

On 10/13/2010 06:22 AM, Daniel P. Berrange wrote:
> On Wed, Oct 13, 2010 at 06:16:03AM -0600, Eric Blake wrote:
> > On 10/13/2010 04:34 AM, Daniel P. Berrange wrote:
> > > The configure.ac file checks for termios.h, but its use is
> > > not protected by HAVE_TERMIOS_H. This breaks the build on
> > > mingw32
> > >
> > > * src/util/util.c: Conditionally include termios.h
> >
> > NACK.  Gnulib provides the termios header replacement, we just need to
> > fix bootstrap.conf to use the gnulib module.
>
> On mingw32 the gnulib replacement does not seem to work though, hence
> configure is undefining HAVE_TERMIOS_H in config.h.
>
> The gnulib replacement is doing an include_next<termios.h>  but there
> is no next one to include.

Then that's a bug in the gnulib replacement.  I'll probably be able to 
fix that today.

> If the gnulib can be relied upon to always provide the header, then
> surely we don't need the termios.h header check in configure.ac ?

Yep, I can do that cleanup in libvirt as well.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org