Re: [PATCH] printf-parse: pull in features.h for __GLIBC__

[Mike Frysinger]

On Thursday, November 18, 2010 19:40:34 Bruno Haible wrote:
> > --- a/lib/printf-parse.h
> > +++ b/lib/printf-parse.h
> > @@ -25,6 +25,9 @@
> > 
> >  #include "printf-args.h"
> > 
> > +#ifdef HAVE_FEATURES_H
> > +# include <features.h>     /* for __GLIBC__ */
> > +#endif
> > 
> >  /* Flags */
> >  #define FLAG_GROUP       1      /* ' flag */
> 
> Why should this be needed? printf-args.h include <wchar.h> and,
> <wchar.h> includes <features.h>. Admittedly this is thin ice, but in
> general we know that every glibc header file includes <features.h>.

except that every glibc header doesnt, and this current reliance on implicit 
inclusion fails on uClibc systems when wchar.h isnt provided.
-mike

signature.asc
Description: This is a digitally signed message part.