Re: [PATCH] ftoastr: new module, for lossless conversion of floats to short strings

[Bruno Haible]

Hi Paul,

Paul Eggert wrote:
> +/* Written by Paul Eggert.  */
> +
> +#include "ftoastr.h"

I'm seeing a compilation error on Solaris 10, in a gnulib testdir of all
modules (generated with
"./gnulib-tool --create-testdir --dir=/tmp/testdir --with-tests 
--with-c++-tests"):

gcc -Wl,-R,/opt/csw/gcc4/lib -std=gnu99 -DHAVE_CONFIG_H -DEXEEXT=\"\" 
-DEXEEXT=\"\" -DNO_XMALLOC  -DEXEEXT=\"\" -I. -I..  -DGNULIB_STRICT_CHECKING=1 
-I../intl  -I/home/haible/prefix-x86/include -Wall -D_REENTRANT  -g -O2 -MT 
ftoastr.o -MD -MP -MF $depbase.Tpo -c -o ftoastr.o ftoastr.c &&\
mv -f $depbase.Tpo $depbase.Po
In file included from ./unistd.h:101,
                 from ./stdio.h:65,
                 from ftoastr.c:32:
./getopt.h:196: error: redefinition of 'struct option'
*** Error code 1

The reason is that the collision of the system's 'struct option' and gnulib's
'struct option' is avoided through __GETOPT_PREFIX, which is defined in 
config.h,
but config.h is not included! This fixes it.


2010-11-27  Bruno Haible  <address@hidden>

        ftoastr: Fix compilation error on Solaris.
        * lib/ftoastr.c: Include <config.h>.

--- lib/ftoastr.c.orig  Sat Nov 27 18:10:18 2010
+++ lib/ftoastr.c       Sat Nov 27 18:09:35 2010
@@ -25,6 +25,8 @@
    This code relies on sprintf, strtod, etc. operating accurately;
    otherwise, the resulting strings could be inaccurate or too long.  */
 
+#include <config.h>
+
 #include "ftoastr.h"
 
 #include "intprops.h"