bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

readline: improve configure output


From: Bruno Haible
Subject: readline: improve configure output
Date: Sun, 28 Nov 2010 02:35:38 +0100
User-agent: KMail/1.9.9

On a Solaris 11 express machine, I'm seeing this output from configure:

  checking for readline...  -ltermcap

which is, at first sight, confusing. Here's an improvement to change this
output to

  checking for readline... yes, requires -ltermcap


2010-11-27  Bruno Haible  <address@hidden>

        readline: Improve configure output.
        * m4/readline.m4 (gl_FUNC_READLINE): Make the
        "checking for readline..." result understandable.

--- m4/readline.m4.orig Sun Nov 28 02:30:49 2010
+++ m4/readline.m4      Sun Nov 28 02:27:16 2010
@@ -1,4 +1,4 @@
-# readline.m4 serial 7
+# readline.m4 serial 8
 dnl Copyright (C) 2005, 2006, 2009, 2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -40,7 +40,12 @@
       AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <stdio.h>
 #include <readline/readline.h>]],
           [[readline((char*)0);]])],
-        [gl_cv_lib_readline=" -l$extra_lib"])
+        [if test -n "$extra_lib"; then
+           gl_cv_lib_readline="yes, requires -l$extra_lib"
+         else
+           gl_cv_lib_readline="yes"
+         fi
+        ])
       if test "$gl_cv_lib_readline" != no; then
         break
       fi
@@ -50,9 +55,10 @@
 
   if test "$gl_cv_lib_readline" != no; then
     AC_DEFINE([HAVE_READLINE], [1], [Define if you have the readline library.])
-    if test "$gl_cv_lib_readline" != " -l"; then
-      LIBREADLINE="$LIBREADLINE$gl_cv_lib_readline"
-      LTLIBREADLINE="$LTLIBREADLINE$gl_cv_lib_readline"
+    extra_lib=`echo "$gl_cv_lib_readline" | sed -n -e 's/yes, requires //p'`
+    if test -n "$extra_lib"; then
+      LIBREADLINE="$LIBREADLINE $extra_lib"
+      LTLIBREADLINE="$LTLIBREADLINE $extra_lib"
     fi
     AC_MSG_CHECKING([how to link with libreadline])
     AC_MSG_RESULT([$LIBREADLINE])
@@ -68,7 +74,7 @@
 
   AC_CHECK_HEADERS([readline/readline.h])
 
-  if test $gl_cv_lib_readline = no; then
+  if test "$gl_cv_lib_readline" = no; then
     AC_LIBOBJ([readline])
     gl_PREREQ_READLINE
   fi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]