[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: unistr use of undefined macros
|
From: |
Eric Blake |
|
Subject: |
Re: unistr use of undefined macros |
|
Date: |
Tue, 07 Dec 2010 14:32:49 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6 |
On 12/07/2010 02:24 PM, Ludovic Courtès wrote:
> Hello,
>
> Commit c98cb289 changed #ifdefs in unistr.in.h to #ifs. As a
> side-effect, this prevents compilation of users of this file, such as
> Guile, with ‘-Wundef’:
Unfortunately, that points to a bug in guile.
Gnulib is explicitly documented as being incompatible with -Wundef; and
while you may choose to use it for the rest of your project, you should
not use it for gnulib files.
See for example how coreutils sets up two distinct CFLAGS, a stricter
one for coreutils files in src/ [1] and a looser one for gnulib files in
lib/ [2]:
[1] http://git.savannah.gnu.org/cgit/coreutils.git/tree/configure.ac#n59
[2] http://git.savannah.gnu.org/cgit/coreutils.git/tree/configure.ac#n117
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature