Re: [bash-testers] Bash-4.2-beta available for FTP

[Eric Blake]

[adding bug-gnulib]

On 12/21/2010 09:58 AM, Joachim Schmitz wrote:
> And I had this:
> cc -c  -I. -I../.. -I../.. -I../../lib -I../../include -I.  -DHAVE_CONFIG_H 
> -DSHELL -DDEBUG  -g -I/usr/local/include  fpurge.c
>   # warning "Please port gnulib fpurge.c to your platform! Look at the 
> definitions of fflush, setvbuf and ungetc on your system, then report this to 
> bug-gnulib."
>     ^
> "/usr/local/Floss/bash-4.2-beta/lib/sh/fpurge.c", line 143: warning(1852):
>           #warning directive: "Please port gnulib fpurge.c to your platform!
>           Look at the definitions of fflush, setvbuf and ungetc on your
>           system, then report this to bug-gnulib."
> 
> My fix:
> 
> diff -u ./lib/sh/fpurge.c.orig ./lib/sh/fpurge.c
> --- ./lib/sh/fpurge.c.orig      2009-04-19 20:12:23.000000000 -0500
> +++ ./lib/sh/fpurge.c   2010-12-21 04:22:05.000000000 -0600
> @@ -101,7 +101,7 @@
>    fp->_wcount = 0;
>    fp->_ungetc_count = 0;
>    return 0;
> -# elif defined _IOERR               /* AIX, HP-UX, IRIX, OSF/1, Solaris, 
> OpenServer, mingw */
> +# elif defined _IOERR               /* AIX, HP-UX, IRIX, OSF/1, Solaris, 
> OpenServer, mingw */ || defined __TANDEM /* HP NonStop */
>    fp->_ptr = fp->_base;
>    if (fp->_ptr != NULL)
>      fp->_cnt = 0;

Can you help us fix the upstream copy of fpurge.c in gnulib to
appropriately cover your platform?  We would also like to port the other
FILE wrapper functions to work with your platform; Bruno Haible has
better instructions on which files need porting and how to best help us,
but I know the list includes freading, fwriting, and fixes for non-POSIX
behavior in fflush and fseeko among others.

Meanwhile, bash's copy of fpurge.c is out of date with upstream gnulib;
it is missing at least the Aug 2009 change that avoids the fpurge
wrapper on cygwin 1.7, now that cygwin provides a working fpurge.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature