Re: linkat on Solaris 11

[Jim Meyering]

Eric Blake wrote:

> On 12/27/2010 11:05 AM, Bruno Haible wrote:
>> Hi Eric, Jim, Paul,
>>
>> On Solaris 11 from 2010-11, I get this test failure:
>>
>>   test-linkat.c:194: assertion failed
>>   /bin/sh: line 10: 4267: Abort(coredump)
>>   FAIL: test-linkat
>>
>> The reason is that this expression
>>   linkat (dfd, BASE "link1", dfd, BASE "sub1/", 0)
>> fails with error ENOTDIR, not EEXIST.
>>
>> Here are two possible fixes: One in the testsuite, one in the linkat()
>> replacement (but this one costs CPU cycles at runtime). Which one do you
>> prefer?
>
> Relaxing the testsuite to permit ENOTDIR is fine with me (and certainly
> cheaper).  No need to make linkat() give a specific errno unless we can
> prove it helps other code to have that exact failure.

Thanks for testing on Solaris 11 and fixing that, Bruno.
Adjusting only the test sounds best to me, too.