[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mountlist: fix local drive detection on cygwin
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] mountlist: fix local drive detection on cygwin |
|
Date: |
Wed, 29 Dec 2010 11:49:26 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 12/29/2010 11:25 AM, Jim Meyering wrote:
> Eric Blake wrote:
>> * lib/mountlist.c (ME_REMOTE) [__CYGWIN__]: Provide implementation
>> that works for cygwin.
>> + if (fs_name[0] && fs_name[1] == ':')
>> + {
>> + char const drive[3] = { fs_name[0], ':' };
>
> Hi Eric,
> Thanks for doing that.
> What do you think about adding an explicit trailing NUL byte there?
>
> char const drive[3] = { fs_name[0], ':', '\0' };
>
> There is probably some rule about partial aggregate initializers
> in C "const" variables that says unspecified elements get 0,
> but it's easy to remove all doubt.
Done, and pushed.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature