Re: [unigbrk 1/2] unigbrk: Fix uc_graphemeclusterbreak_property(), add comprehensive test.

[Ben Pfaff]

Bruno Haible <address@hidden> writes:

>> +++ b/tests/unigbrk/test-uc-gbrk-prop.c
>> ...
>> +              fprintf (stderr, "uc_graphemeclusterbreak_property(%#x) "
>> +                       "yielded %s but should have been %s\n",
>> +                       uc, graphemebreakproperty_to_string (retval),
>> +                       graphemebreakproperty_to_string (r->gbp));
>> +              abort ();
>> +            }
>> +        }
>> +    }
>> +  ASSERT (uc == 0x110000);
>> +
>> +  return 0;
>> +}
>
> Here it would be good to insert an
>   fflush (stderr);
> statement between the fprintf and the abort statements. Reason: On mingw,
> stdio buffers are not flushed when abort() is called, i.e. their contents
> gets lost.

Does this mean that mingw also fully buffers stderr?  This is a
violation of the C standard, which says, "As initially opened,
the standard error stream is not fully buffered; [...]".

Anyway, I added the fflush.

> Otherwise perfect, please push this one.

Thank you, I will do so soon.
-- 
Ben Pfaff 
http://benpfaff.org