Re: [PATCH] bootstrap: support --no-git option

[Eric Blake]

On 01/20/2011 11:54 AM, Eric Blake wrote:
> From: Benjamin Lindner <address@hidden>
> 
> * build-aux/bootstrap: Add --no-git option, to be used when
> --gnulib-srcdir points to the exact desired checkout.
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
> 
> I'd like to push this in your name, once I have your okay.  The
> (tiny change) notation reflects your copyright status, and is
> not demeaning the work you put into this.


> + --no-git                 Do not update gnulib using git. Requires that
> +                          --gnulib-srcdir points to a complete gnulib source
> +                          tree

I'm tweaking this (two spaces after ., trailing . to match other options
[although that's debatable, it would take a separate patch to clean up
the usage for all options], sorting before --skip-po, and more concise):

>  --no-git                 Do not use git to update gnulib.  Requires that
>                           --gnulib-srcdir point to a correct gnulib snapshot.

> +  echo "Error: --no-git requires --gnulib-srcdir" >&2

Needs $0 in the message.

> @@ -384,6 +400,10 @@ check_versions() {
>      if test "$app" = libtool; then
>        app=libtoolize
>      fi
> +    # only test for git if not using --no-git

And that comment was a double-negative, rewritten as:

> # Exempt git if --no-git is in effect.

I went ahead and pushed this, since libvirt (at least) is clamoring to
have it sooner rather than later.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature