Re: ignore-value vs off_t

[Simon Josefsson]

Eric Blake <address@hidden> writes:

> +     ignore-value: add missing test dependency
> +     * tests/test-ignore-value.c: Revert previous change; stdio.h
> +     provides off_t.
> +     * modules/ignore-value-tests (Depends-on): Add missing dependency.

Thanks, this looks like the correct fix and it works for me.  I've
pushed the patch below to improve documentation.

/Simon

>From ddf6704b29173e809f3b0150c015ca282e06388f Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Mon, 31 Jan 2011 16:00:08 +0100
Subject: [PATCH] doc: off_t is not available in eglibc 2.11.2 stdio.h.

* doc/posix-headers/stdio.texi (stdio.h): Mention that off_t isn't
declared by eglibc 2.11.2.
* lib/stdio.in.h: Likewise.
---
 ChangeLog                    |    7 +++++++
 doc/posix-headers/stdio.texi |    2 +-
 lib/stdio.in.h               |    3 ++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6ab5e34..360f0dd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-01-31  Simon Josefsson  <address@hidden>
+
+       doc: off_t is not available in eglibc 2.11.2 stdio.h.
+       * doc/posix-headers/stdio.texi (stdio.h): Mention that off_t isn't
+       declared by eglibc 2.11.2.
+       * lib/stdio.in.h: Likewise.
+
 2011-01-31  Eric Blake  <address@hidden>
 
        ignore-value: add missing test dependency
diff --git a/doc/posix-headers/stdio.texi b/doc/posix-headers/stdio.texi
index 89b9576..e4157a7 100644
--- a/doc/posix-headers/stdio.texi
+++ b/doc/posix-headers/stdio.texi
@@ -9,7 +9,7 @@ Portability problems fixed by Gnulib:
 @itemize
 @item
 The type @code{off_t} is missing on some platforms:
-glibc 2.8 and others.
+glibc 2.8, eglibc 2.11.2 and others.
 @item
 The type @code{ssize_t} is missing on some platforms:
 glibc 2.8, MacOS X 10.5, Solaris 10, and others.
diff --git a/lib/stdio.in.h b/lib/stdio.in.h
index 6aee8fb..f61a572 100644
--- a/lib/stdio.in.h
+++ b/lib/stdio.in.h
@@ -52,7 +52,8 @@
 
 #include <stddef.h>
 
-/* Get off_t and ssize_t.  Needed on many systems, including glibc 2.8.  */
+/* Get off_t and ssize_t.  Needed on many systems, including glibc 2.8
+   and eglibc 2.11.2.  */
 #include <sys/types.h>
 
 #ifndef __attribute__
-- 
1.7.2.3