bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: adjust cpp indentation for my modules, as well


From: Jim Meyering
Subject: Re: [PATCH] maint: adjust cpp indentation for my modules, as well
Date: Tue, 22 Feb 2011 20:58:03 +0100

Paul Eggert wrote:
> On 02/22/2011 07:57 AM, Jim Meyering wrote:
>> I omitted getloadavg.c since it had so many violations
>> and is soooo crufty, and since Paul just got it into emacs.
>> However, considering the number of cpp conditionals, it might
>> benefit from the conversion.  Paul, what do you think?
>
> I have no objections.
>
> Though I hope you mind that I don't volunteer; the
> cruft-to-actual-utility ratio is pretty high in that one.

I think getloadavg.c holds the record on that front,
which is why I haven't spent any time on it in ages.

There's no point even in indenting its cpp directives.
lipstick on a pig.

> I'm reasonably sure that many of its sections are completely
> obsolete and wouldn't work properly even if the corresponding
> operating systems were actually used.  If you have a bit of time to
> look at the code, it may be better to spend the time ripping out
> craft rather than reindenting it.

No, thanks ;-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]