Re: [PATCH] maint.mk: suppress a syntax check false positive

[Pádraig Brady]

On 11/03/11 09:32, Jim Meyering wrote:
> Pádraig Brady wrote:
>> A recent change to dd in coreutils triggered this issue,
>> which is avoided with the attached.
> 
> Thanks!
> I've pushed that.

Cool, thanks.
I have gnulib commit access BTW
I had a local tweak to remove an extraneous ( in the Changelog,
but that's inconsequential.

> 
>> +    maint.mk: suppress a false positive warning
>> +    * top/maint.mk ((sc_unmarked_diagnostics): Don't warn when
>> +    diagnostics are marked with ngettext.
> ...
>> diff --git a/top/maint.mk b/top/maint.mk
> ...
>>  sc_unmarked_diagnostics:
>>      @grep -nE                                                       \
>>          '\<error *\([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT))      \
>> -      | grep -v '_''(' &&                                           \
>> +      | grep -Ev '(_|ngettext )\(' &&                               \
> 
> Then wondered if we should be more permissive in what we filter out,
> perhaps by allowing 0 or more spaces between ngettext and the following "(":
> 
>         | grep -Ev '(_|ngettext *)\(' &&                              \
> 
> It's probably not worth anchoring the left side of "ngettext"
> to a word boundary.

If gnulib checks don't assume or enforce a space between
function name and '(', then I would amend as above.

cheers,
Pádraig.