Re: verror.h should use _GL_ATTRIBUTE_FORMAT

[Bruno Haible]

Hello Tom,

> I ran into a build error when building GNU m4 1.4.16 with the SGI
> compiler on IRIX 5.3 and 6.2.
> The problem turned out to be in verror.h from gnulib. It uses the
> __attribute__ format directive directly instead of the usual
> _GL_ATTRIBUTE_FORMAT macro.

Oops, that's a bug I introduced on 2011-02-13. I'm applying this fix. Thanks
for the report!


2011-03-20  Bruno Haible  <address@hidden>

        verror: Fix compilation error introduced on 2011-02-13.
        * lib/verror.h (verror, verror_at_line): Use _GL_ATTRIBUTE_FORMAT macro
        instead of __attribute__.
        Reported by Tom G. Christensen <address@hidden>.

--- lib/verror.h.orig   Sun Mar 20 22:31:36 2011
+++ lib/verror.h        Sun Mar 20 22:31:06 2011
@@ -17,9 +17,10 @@
 #ifndef _VERROR_H
 #define _VERROR_H 1
 
-#include "error.h"
 #include <stdarg.h>
 
+#include "error.h" /* for _GL_ATTRIBUTE_FORMAT */
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -32,7 +33,7 @@
 
 extern void verror (int __status, int __errnum, const char *__format,
                     va_list __args)
-     __attribute__ ((__format__ (__printf__, 3, 0)));
+     _GL_ATTRIBUTE_FORMAT ((__printf__, 3, 0));
 
 /* Print a message with `vfprintf (stderr, FORMAT, ARGS)';
    if ERRNUM is nonzero, follow it with ": " and strerror (ERRNUM).
@@ -44,7 +45,7 @@
 extern void verror_at_line (int __status, int __errnum, const char *__fname,
                             unsigned int __lineno, const char *__format,
                             va_list __args)
-     __attribute__ ((__format__ (__printf__, 5, 0)));
+     _GL_ATTRIBUTE_FORMAT ((__printf__, 5, 0));
 
 #ifdef __cplusplus
 }

-- 
In memoriam Jan Nepomucký <http://en.wikipedia.org/wiki/John_of_Nepomuk>