Re: [PATCH 1/4] nonblocking: provide O_NONBLOCK for mingw

[Bruno Haible]

Hi Eric,

Thanks for the review.

Eric Blake wrote:
> > --- doc/posix-functions/open.texi.orig      Sun Apr 17 23:18:36 2011
> > +++ doc/posix-functions/open.texi   Sun Apr 17 23:08:20 2011
> > @@ -14,6 +14,10 @@
> >  directory, on some platforms:
> >  FreeBSD 7.2, AIX 7.1, HP-UX 11.00, Solaris 9, Irix 5.3.
> >  @item
> > +This function does not support the @code{O_NONBLOCK} flag when it is 
> > defined
> > +by the gnulib module @code{nonblock} on some platforms:
> > +mingw.
> > address@hidden
> 
> openat() needs the same disclaimer, then.

'openat' is not present on mingw, therefore this documentation does not apply
to openat. And the module 'openat' depends already on the module 'open', hence
a user who wants to openat() with O_NONBLOCK and asks for the modules 'openat'
and 'nonblock' will get what he needs.

> > +  dnl Replace open() for supporting the gnulib-defined O_NONBLOCK flag.
> > +  m4_ifdef([gl_NONBLOCKING_IO], [
> > +    if test $REPLACE_OPEN = 0; then
> > +      gl_NONBLOCKING_IO
> > +      if test $gl_cv_have_open_O_NONBLOCK != yes; then
> > +        gl_REPLACE_OPEN
> > +      fi
> > +    fi
> > +  ])
> 
> Makes sense.

I've pushed it.

Bruno
-- 
In memoriam Charles Delestraint 
<http://en.wikipedia.org/wiki/Charles_Delestraint>