[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Proposed patches to remove several inttypes-related dependencies
From: |
Eric Blake |
Subject: |
Re: Proposed patches to remove several inttypes-related dependencies |
Date: |
Fri, 22 Apr 2011 04:34:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9 |
On 04/22/2011 03:54 AM, Paul Eggert wrote:
> Subject: [PATCH 7/7] Fix typo in modules/strtoumax: it needs strtoul.c too.
>
> ---
> ChangeLog | 2 +-
> modules/strtoumax | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index babb259..675c895 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -44,7 +44,7 @@
> strtoumax: remove dependency on strtoimax, strtoull
> This is like the strtoimax change.
> * modules/strtoumax (Files): Add lib/strtoimax.c, lib/strtol.c,
> - lib/strtoull.c, m4/strtoull.m4.
> + lib/strtoul.c, lib/strtoull.c, m4/strtoull.m4.
Rather than fixing after the fact, can't you do 'git rebase -i origin',
move that line up next to the patch where it is needed, change 'edit' to
'squash', and thereby amend the commit into a single commit that does
the right thing in the first place?
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: Proposed patches to remove several inttypes-related dependencies, (continued)
- Re: Proposed patches to remove several inttypes-related dependencies, Eric Blake, 2011/04/22
- Re: [1/7] Proposed patches to remove several inttypes-related dependencies, Eric Blake, 2011/04/22
- Re: [2/7] Proposed patches to remove several inttypes-related dependencies, Eric Blake, 2011/04/22
- Re: [3/7] Proposed patches to remove several inttypes-related dependencies, Eric Blake, 2011/04/22
- Re: [6/7] Proposed patches to remove several inttypes-related dependencies, Eric Blake, 2011/04/22
- Re: Proposed patches to remove several inttypes-related dependencies,
Eric Blake <=
- Re: [1/7] Proposed patches to remove several inttypes-related dependencies, Bruno Haible, 2011/04/24
- Re: [2/7][7/7] Proposed patches to remove several inttypes-related dependencies, Bruno Haible, 2011/04/24
- Re: [3/7][4/7][5/7] Proposed patches to remove several inttypes-related dependencies, Bruno Haible, 2011/04/24
- Re: [6/7] Proposed patches to remove several inttypes-related dependencies, Bruno Haible, 2011/04/24