[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] getcwd: consolidate m4 files
From: |
Jim Meyering |
Subject: |
Re: [PATCH 1/3] getcwd: consolidate m4 files |
Date: |
Tue, 26 Apr 2011 07:55:19 +0200 |
Eric Blake wrote:
> It was confusing having 1 out of 3 known getcwd problems checked
> in place, and the other two in separate files.
>
> * m4/getcwd-abort-bug.m4, m4/getcwd-path-max.m4: Delete, moving
> contents...
> * m4/getcwd.m4: Here.
> * modules/getcwd (Files): Reflect the motion.
I have mixed feelings about this. On one hand, it's obviously safe.
On the other, it would make getcwd.m4 the 9th largest of
gnulib's 600+ .m4 files.
$ wc -l m4/getcwd*
106 m4/getcwd-abort-bug.m4
188 m4/getcwd-path-max.m4
85 m4/getcwd.m4
379 total
Considering that each of those two tests is stand-alone,
I find it preferable to keep them in separate files, but not by much,
so won't object if you still want to combine the three into one.