Re: [PATCHv2 4/9] save-cwd: reduce dependency

[Eric Blake]

On 04/27/2011 10:03 AM, Jim Meyering wrote:
> Eric Blake wrote:
>> On 04/27/2011 01:37 AM, Jim Meyering wrote:
>>> Eric Blake wrote:
>>>> save-cwd needs either a working fchdir or a working getcwd(NULL).
>>>> The only platform where getcwd fixes problems not solved by
>>>> getcwd-lgpl is Linux, but fchdir works there.
>>>>
> Reducing robustness solely to reduce dependencies...
> That could introduce a subtle flaw in a package that depends on the
> robustness -- if the package maintainer doesn't read gnulib's NEWS.
> Not so sure I like that, but I do recognized the value.
> 
> I guess it's ok if it's well documented.
> Be sure to mention in NEWS that by default (without explicit
> inclusion of the getcwd module), the save-cwd module is no longer robust.

I updated NEWS and the save-cwd.c comments as recommended, as well as
reworded the commit message to be more verbose about the issue, then pushed.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature