[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 9/9] fchdir: avoid extra chdir and fix test
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCHv2 9/9] fchdir: avoid extra chdir and fix test |
|
Date: |
Wed, 27 Apr 2011 15:10:56 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9 |
On 04/26/2011 05:35 PM, Eric Blake wrote:
> On Linux, with a forced ac_cv_func_fchdir=no, the test failed
> because dup2 was not replaced, all because the shell variable
> ac_cv_func_dup2 had not been set yet.
>
> Meanwhile, computing the canonical pathname of a directory on
> mingw was rather expensive -- multiple chdir()! -- but nothing
> cared whether the name was canonical, just that it was absolute.
>
> * modules/fchdir (Depends-on): Add dosname, filenamecat-lgpl,
> getcwd-lgpl.
> * lib/fchdir.c (get_name): Any absolute name will do; it does not
> have to be canonical.
> * m4/dup2.m4 (gl_REPLACE_DUP2): Ensure dup2 is replaced.
I've gone ahead and pushed this, after making one more cleanup (the code
no longer needed to define HAVE_CANONICALIZE_FILE_NAME).
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCHv2 5/9] dirent-safer: drop unused link dependency, (continued)
- [PATCHv2 6/9] tests: reduce dependencies, Eric Blake, 2011/04/26
- [PATCHv2 3/9] getcwd: enhance tests, Eric Blake, 2011/04/26
- [PATCHv2 7/9] linkat, renameat: add missing dependency, Eric Blake, 2011/04/26
- [PATCHv2 8/9] filenamecat-lgpl: fix licence, Eric Blake, 2011/04/26
- [PATCHv2 9/9] fchdir: avoid extra chdir and fix test, Eric Blake, 2011/04/26
- Re: [PATCHv2 9/9] fchdir: avoid extra chdir and fix test,
Eric Blake <=