Re: git-version-gen and EXTRA_DIST

[Simon Josefsson]

Eric Blake <address@hidden> writes:

> On 04/30/2011 09:53 AM, Simon Josefsson wrote:
>> I got a report [1] that it wasn't possible to run 'autoreconf' in a
>> distribution tarball because build-aux/git-version-gen was not
>> distributed.  Is this intended to work automatically somehow?
>> Otherwise, how about this patch?
>> 
>> /Simon
>> 
>> [1]
>> http://lists.nongnu.org/archive/html/oath-toolkit-help/2011-04/msg00039.html
>> 
>> diff --git a/modules/git-version-gen b/modules/git-version-gen
>> index a783ac5..e42dff0 100644
>> --- a/modules/git-version-gen
>> +++ b/modules/git-version-gen
>> @@ -1,6 +1,9 @@
>>  Description:
>>  Compute a version string from a git repository.
>>  
>> +Notice:
>> +You must add EXTRA_DIST += build-aux/git-version-gen to Makefile.am.
>
> Even better would be to put the EXTRA_DIST line under the configure.ac
> portion of the module file.

Why configure.ac?  The line needs to go into Makefile.am.  Could you
point to some other module that does that, for comparison?

> There are probably other modules, like gnupload, that could also
> benefit from that sort of treatment.

Yes, and update-copyright.

/Simon