[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] mark functions with const and pure attributes
From: |
Jim Meyering |
Subject: |
Re: [PATCH 1/2] mark functions with const and pure attributes |
Date: |
Sun, 01 May 2011 18:22:43 +0200 |
Paul Eggert wrote:
> On 05/01/11 06:31, Jim Meyering wrote:
>> +# define _GL_ATTRIBUTE_PURE __attribute__ ((__pure__))
>
> The names _GL_ATTRIBUTE_PURE and _GL_ATTRIBUTE_CONST seem
> gratingly long to me; when reading a function signature they
> get in the way of other important information. Also, these
> two names use a different naming convention from _GL_UNUSED.
> How about following _GL_UNUSED's lead, and renaming
> them to _GL_PURE and _GL_CONST? When used in context
> the shorter names shouldn't be confusing.
"grating" is a good way to put it.
Sure, I'll adjust.